Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix issue when averaging spectra in aquired in profile mode #244

Closed
wants to merge 1 commit into from
Closed

[WIP] Fix issue when averaging spectra in aquired in profile mode #244

wants to merge 1 commit into from

Conversation

MKoesters
Copy link
Contributor

Changes

Todo

  • check for side effets of this fix
  • add test with file aquired in profile mode

@MKoesters MKoesters linked an issue Jun 22, 2020 that may be closed by this pull request
Issue Averaging Two Spectra #240
Open
@MKoesters MKoesters self-assigned this Jun 22, 2020
@MKoesters MKoesters mentioned this pull request Jun 22, 2020
Open
@codecov
Copy link

codecov bot commented Jun 22, 2020 •
edited
Loading

Codecov Report

Merging #244 into dev will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #244      +/-   ##
==========================================
+ Coverage   84.19%   84.20%   +0.01%     
==========================================
  Files          32       32              
  Lines        3701     3704       +3     
==========================================
+ Hits         3116     3119       +3     
  Misses        585      585
Impacted Files Coverage Δ
pymzml/spec.py 77.24% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956f035...06c2bca. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fu fu closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fu fu fu approved these changes

Assignees

@MKoesters MKoesters

Labels
bug_fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue Averaging Two Spectra
2 participants
@MKoesters @fu