Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hl fixes #428

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Hl fixes #428

merged 6 commits into from
Sep 20, 2023

Conversation

awegsche
Copy link
Contributor

@awegsche awegsche commented Sep 20, 2023

this adds a couple of fixes related to hl

  • important phase advances are not yet defined for HL

"The names of tertiaries are different in HL and in general everything in between q5 to Q5 is different. The phase advances for HL are likely different from LHC. We will finalise likely towards oct-nov 2023 after we will perform further optimizations."
-- Riccardo De Maria

  • the response creator used the formatting +f for delta_k, which only printed exactly 6 decimal spaces. consequently, values below 1e-6 were written as 0 into the job file.

@awegsche
Copy link
Contributor Author

how does this change break plotting?

omc3/model/accelerators/lhc.py Outdated Show resolved Hide resolved
omc3/model/accelerators/lhc.py Outdated Show resolved Hide resolved
@fsoubelet
Copy link
Member

fsoubelet commented Sep 20, 2023

Seems like a new version of matplotlib stopped accepting use_line_collection kwarg: https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.8.0.html#parameters-to-plt-figure-and-the-figure-constructor.

@JoschD can you have a look when you've got time?

@JoschD JoschD mentioned this pull request Sep 20, 2023
@codeclimate
Copy link

codeclimate bot commented Sep 20, 2023

Code Climate has analyzed commit 595c618 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 75.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.8%.

View more on Code Climate.

@awegsche awegsche merged commit 2ae8acb into master Sep 20, 2023
34 checks passed
@JoschD JoschD deleted the hl_fixes branch October 16, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants