Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PYIRON_CORES and PYIRON_THREADS #73

Merged
merged 3 commits into from
Jun 28, 2024
Merged

use PYIRON_CORES and PYIRON_THREADS #73

merged 3 commits into from
Jun 28, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jun 28, 2024

By using ${PYIRON_CORES:=$1} we fall back to $1 in case $PYIRON_CORES is not defined. With this change the conversion is backwards compatible.

Other changes:

  • VASP, LAMMPS and Sphinx version number is update
  • The templates folder is removed as it is now recommended to use wrap_executable() and wrap_python_function().

@jan-janssen jan-janssen requested a review from pmrv June 28, 2024 09:01
@@ -0,0 +1,2 @@
#!/bin/bash
mpiexec -n ${PYIRON_CORES:=$1} --oversubscribe lmp_mpi -in control.inp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intending to get the conda version of lammps from the pyiron/... module? Then I would like to make that more explicity by

Suggested change
mpiexec -n ${PYIRON_CORES:=$1} --oversubscribe lmp_mpi -in control.inp;
module purge
module pyiron
mpiexec -n ${PYIRON_CORES:=$1} --oversubscribe lmp_mpi -in control.inp;

and renaming the script to include conda or so "conda", since in the current way it's not actually guaranteed that we end up with lammps 2024 Feb07.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we have some confusion here - these are the general pyiron resources people download when they install pyiron from conda, so yes it is using LAMMPS from conda and by default there is no module system available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still use this. Making 6 the default makes sense, but it's ok to keep the old version for a while.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is primarily a template as inspiration for users - these are not the resources we use one the cluster.

@pmrv
Copy link
Contributor

pmrv commented Jun 28, 2024

Ah, right, sorry, I had confused with our internal. :(

@jan-janssen jan-janssen merged commit aba8b8e into main Jun 28, 2024
1 check passed
@jan-janssen jan-janssen deleted the env branch June 28, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants