-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use PYIRON_CORES and PYIRON_THREADS #73
Conversation
@@ -0,0 +1,2 @@ | |||
#!/bin/bash | |||
mpiexec -n ${PYIRON_CORES:=$1} --oversubscribe lmp_mpi -in control.inp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intending to get the conda version of lammps from the pyiron/...
module? Then I would like to make that more explicity by
mpiexec -n ${PYIRON_CORES:=$1} --oversubscribe lmp_mpi -in control.inp; | |
module purge | |
module pyiron | |
mpiexec -n ${PYIRON_CORES:=$1} --oversubscribe lmp_mpi -in control.inp; |
and renaming the script to include conda or so "conda", since in the current way it's not actually guaranteed that we end up with lammps 2024 Feb07.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we have some confusion here - these are the general pyiron resources people download when they install pyiron from conda, so yes it is using LAMMPS from conda and by default there is no module system available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still use this. Making 6 the default makes sense, but it's ok to keep the old version for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is primarily a template as inspiration for users - these are not the resources we use one the cluster.
Ah, right, sorry, I had confused with our internal. :( |
By using
${PYIRON_CORES:=$1}
we fall back to$1
in case$PYIRON_CORES
is not defined. With this change the conversion is backwards compatible.Other changes:
templates
folder is removed as it is now recommended to usewrap_executable()
andwrap_python_function()
.