Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jira/client.py: Map IssueLinkType array to string array #1876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ssamsel-rtx
Copy link

Equality check between IssueLinkType and string always returns false. Function decorator casts IssueLinkType parameters to string, so a warning is always logged. This fixes that issue.

Closes: #1875

Equality check between IssueLinkType and string always returns false.
Function decorator casts IssueLinkType parameters to string, so a
warning is always logged. This fixes that issue.

Closes: pycontribs#1875
Signed-off-by: Shymon Samsel <[email protected]>
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for this. I want to have a think of a test case to make sure we don't cause regressions on this moving forward, so will have a think before merging

@KiloFoxtrotPapa
Copy link

This fix won't work. You'll break the for loop later when it tries to access .outward and .inward
Fix should probably go on the if line?

        if type not in [lt.name for lt in issue_link_types]:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erroneous Warnings When Creating Issue Links
3 participants