-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algolia docsearch #3159
Algolia docsearch #3159
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #3159 +/- ##
========================================
Coverage 99.71% 99.71%
========================================
Files 248 248
Lines 18763 18763
========================================
Hits 18709 18709
Misses 54 54 ☔ View full report in Codecov by Sentry. |
A potential solution based on https://github.com/pystatgen/sgkit/pull/668.
This reverts commit a936428.
Some updates: there are definitely ways to make Algolia work with the PyData Sphinx Theme—the
There seems to be a |
This should be ready for review/merge now once tests pass—apparently the error about I also added a few CSS customisations so that the elements resemble the PyData Sphinx Theme. The new, blazing-fast search can be tried here: https://pybamm--3159.org.readthedocs.build/en/3159/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's super fast! Thanks for working on this, @agriyakhetarpal!
Before we merge this I just want to make sure that the position is correct on smaller screens and try it on a Windows system which uses Ctrl instead of ⌘ in the search box |
Sounds good, let us know when this is ready to merge. |
Good to go now! |
Description
This PR adds Algolia DocSearch v3 since our application was accepted recently. Third-party search functionality is not supported with PyData Sphinx Theme yet (pydata/pydata-sphinx-theme#202, pydata/pydata-sphinx-theme#795
Therefore, manual templates are added along with the
sphinx-docsearch
extension from Algolia to render the search bar. This disables the default search bar.Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
$ python run-tests.py --doctest
You can run unit and doctests together at once, using
$ python run-tests.py --quick
.Further checks: