Ensure that #170 doesn't regress #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
force-pushed
the
iwahbe/ensure-170-doesnt-regress
branch
from
456fcca
to
5b191ba
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Fixes #528 I have removed the diff replay test since it doesn't capture the issue anymore. I have replaced this with an integration test since we need to ensure that "Check" behaves such that diff doesn't present an issue.
iwahbe
force-pushed
the
iwahbe/ensure-170-doesnt-regress
branch
from
5b191ba
to
1e3076a
Compare
VenelinMartinov
approved these changes
Jun 12, 2024
Unfortunately yes. The fix works only when it depends on the next TF release. |
|
Merged as part of #545. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #528
I have removed the diff replay test since it doesn't capture the issue anymore. I have replaced this with an integration test since we need to ensure that "Check" behaves such that diff doesn't present an issue.
Needs to merge after the next (v3.85.0) bridge release.