Cloudrun service fix 409 conflict due to not refreshing by default #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
There was a problem hiding this comment.
Looks sensible! Can you please add a test for this similar to
pulumi-gcp/provider/provider_yaml_test.go
Line 977 in c39bf95
rshade
force-pushed
the
rshade/issue-350
branch
5 times, most recently
from
8e18093
to
6bb68cc
Compare
rshade
force-pushed
the
rshade/issue-350
branch
from
6bb68cc
to
bfc2819
Compare
VenelinMartinov
changed the title
VenelinMartinov
approved these changes
Nov 14, 2024
VenelinMartinov
approved these changes
Nov 14, 2024
|
This PR has been shipped in release v8.9.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with the
cloud_run_serviceresource which causes a 409 conflict with the service whenever there is a change outside of pulumi. The conflict is caused by theresourceVersionproperty in themetadatablob, which is used for optimistic locking.This change adds a
TransformFromStatehook to the resource which deletes theresourceVersionfrom the state. This disables the optimistic locking behaviour and prevents the 409 conflicts caused by changes to the resource.fixes #350