Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup version prefix #1335

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Cleanup version prefix #1335

merged 2 commits into from
Nov 14, 2023

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Nov 14, 2023

We set VERSION_PREFIX temporarily during the v7 release to make sure pulumictl versions code as 7.x.x; it is no longer necessary now that pulumictl will be finding a 7.x. tag in Git history.

Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 requested a review from a team November 14, 2023 02:52
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good old VERSION_PREFIX, confuser of developers

@t0yv0 t0yv0 merged commit f951d40 into master Nov 14, 2023
17 checks passed
@t0yv0 t0yv0 deleted the t0yv0/cleanup-version-prefix branch November 14, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants