-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: update deps and correctly map resource/property names (#129)
This PR does a couple of different things. I was originally going to try and split it into multiple PRs, but there were too many dependencies between the changes 1. switches the test runner from `mocha` to `jest` to align with our other node based projects (like `awsx`). 2. Added some tests for [cfn-resource-mappings](https://github.com/pulumi/pulumi-cdk/blob/main/src/cfn-resource-mappings.ts) and [aws-resource-mappings](https://github.com/pulumi/pulumi-cdk/blob/main/src/aws-resource-mappings.ts) 3. Update dependencies to newest versions - Also moved `@pulumi/*` and `aws-cdk` dependencies from `dependencies` to `peerDependencies` which allows users to determine which versions they want to install. 3a. As part of the dependency updates had to fix some of the mappings - Update `iam.Role` mapping to correctly map the `Policies` property. - Update `s3objectlambda.AccessPoint` to correctly map `contentTransformation` properties. - Update `autoscaling.Group` properties correctly - Update `ec2.Route` properties (remove `instanceId` prop) 4. Implement a TypeScript version of the [naming](https://github.com/pulumi/pulumi-aws-native/blob/master/provider/pkg/naming/naming.go) package from `aws-native` so that we will more reliably map resource/property names between CFN and pulumi. **Note on peerDependencies** peerDependencies allow us to specify a minimum required version that works with our library and then the user can decide which version to install. I think as we (or the community) develops more component libraries it might be more important to use peerDependencies. When there are multiple libraries that all depend on some core library and they all specify the core library as a `dependency` then there will be multiple versions of that core library installed. Sometimes this can cause incompatibility between libraries. The article below goes into some more detail. [dev.to/aws-builders/correctly-defining-dependencies-in-l3-cdk-constructs-45p](https://dev.to/aws-builders/correctly-defining-dependencies-in-l3-cdk-constructs-45p)
- Loading branch information
Showing
28 changed files
with
5,152 additions
and
1,357 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -113,3 +113,6 @@ dist | |
|
||
# IntelliJ | ||
.idea/ | ||
|
||
test-reports/ | ||
lib/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.