Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-azurerm to v4.9.0 #2632

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented Nov 14, 2024

This PR was generated via $ upgrade-provider pulumi/pulumi-azure --kind=all --target-bridge-version=latest.

Manual edits:


@thomas11 thomas11 added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Nov 14, 2024
Copy link

github-actions bot commented Nov 14, 2024

Does the PR have any schema changes?

Found 6 breaking changes:

Resources

  • 🟢 "azure:storage/container:Container": required: "storageAccountName" property is no longer Required
  • 🟢 "azure:storage/share:Share": required: "storageAccountName" property is no longer Required

Types

  • "azure:storage/AccountQueuePropertiesHourMetrics:AccountQueuePropertiesHourMetrics":
    • 🟡 properties: "enabled" missing
    • 🟢 required: "enabled" property is no longer Required
  • "azure:storage/AccountQueuePropertiesMinuteMetrics:AccountQueuePropertiesMinuteMetrics":
    • 🟡 properties: "enabled" missing
    • 🟢 required: "enabled" property is no longer Required

New resources:

  • cosmosdb/mongoCluster.MongoCluster
  • dashboard/grafanaManagedPrivateEndpoint.GrafanaManagedPrivateEndpoint
  • dataprotection/backupInstanceMysqlFlexibleServer.BackupInstanceMysqlFlexibleServer
  • dynatrace/monitor.Monitor
  • stack/hciNetworkInterface.HciNetworkInterface
  • storage/accountQueueProperties.AccountQueueProperties
  • storage/accountStaticWebsite.AccountStaticWebsite

Maintainer note: consult the runbook for dealing with any breaking changes.

@thomas11 thomas11 requested review from danielrbradley and a team November 14, 2024 11:58
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall upgrade looks good. I think we should fail fast rather than ignore the type error in the mixins though.

sdk/nodejs/storage/zMixins.ts Outdated Show resolved Hide resolved
@thomas11 thomas11 enabled auto-merge (squash) November 14, 2024 14:16
@thomas11 thomas11 merged commit 1468c82 into master Nov 14, 2024
23 checks passed
@thomas11 thomas11 deleted the upgrade-terraform-provider-azurerm-to-v4.9.0 branch November 14, 2024 15:07
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.9.0.

@github-actions github-actions bot removed the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-azurerm to v4.9.0
3 participants