Test against pulumi/examples #1717
Draft
+287
−2,268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomas11
commented
Feb 14, 2024
thomas11
commented
- Add pulumi/examples tests to examples/ test suite
- Temporarily add regenerated ci-mgmt workflows directly
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
thomas11
force-pushed
the
tkappler/test-pulumi-examples
branch
2 times, most recently
from
44cc971
to
de1736e
Compare
thomas11
force-pushed
the
tkappler/test-pulumi-examples
branch
from
de1736e
to
98d5f84
Compare
thomas11
force-pushed
the
tkappler/test-pulumi-examples
branch
from
98d5f84
to
60738de
Compare
thomas11
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Feb 26, 2024
…test suite (#823) This change adds a new optional flag `testPulumiExamples` that can be set in .ci-mgmt.yaml. When set, the acceptance tests in pulumi/examples will be run as part of the test suite. The goal is to increase test coverage in provider PRs or releases. `pulumi/examples` has a rich set of realistic programs that can be used for this via ProgramTest. Providers don't necessarily need to gate PRs on these tests, they can be informational only. This requires that the provider's test suite in `examples/` is enabled for this. See pulumi/pulumi-azure#1717 for an example. It's not enough to just run the test suite in pulumi/examples because we want to use or inject the locally built provider and SDKs of the current PR. I chose the approach using the test job's matrix because the new pulumi/examples tests should run concurrently to the regular ones, but to run them in a separate job would require copying the lengthy setup steps of the test job, or extracting the setup into a composite action which I thought could be avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.