Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ResourceProvider.configure #13276

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Nov 7, 2024

In pulumi/pulumi#17673 and pulumi/pulumi#17697 we introduced a new optional configure method that has access to the stack configuration.

Wait for the next Pulumi release before merging this

In pulumi/pulumi#17673 and pulumi/pulumi#17697 we introduced a new optional configure method that has access to the stack configuration.

Wait for the next Pulumi release before merging this
@julienp julienp marked this pull request as ready for review November 7, 2024 14:27
@julienp julienp requested a review from a team as a code owner November 7, 2024 14:27
@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@lunaris lunaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits from me but looks good! Will leave to docs team to stamp though 🙇

content/docs/iac/concepts/resources/dynamic-providers.md Outdated Show resolved Hide resolved
{{% choosable language java %}}

```java
// Dynamic Providers are currently not supported in Java.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: consistent language across all these? E.g. are currently not supported in X.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah I blindly copy pasted from another example. I'll fix it all up!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just the YAML one in all cases that's different. Could this be intentional? We can never have dynamic providers, but we could at some point have them for other languages, even if unlikely.

@pulumi-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants