-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document ResourceProvider.configure #13276
base: master
Are you sure you want to change the base?
Conversation
In pulumi/pulumi#17673 and pulumi/pulumi#17697 we introduced a new optional configure method that has access to the stack configuration. Wait for the next Pulumi release before merging this
Your site preview for commit f42a8f5 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13276-f42a8f51.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits from me but looks good! Will leave to docs team to stamp though 🙇
{{% choosable language java %}} | ||
|
||
```java | ||
// Dynamic Providers are currently not supported in Java. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: consistent language across all these? E.g. are currently not supported in X
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah I blindly copy pasted from another example. I'll fix it all up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just the YAML one in all cases that's different. Could this be intentional? We can never have dynamic providers, but we could at some point have them for other languages, even if unlikely.
Co-authored-by: Will Jones <[email protected]>
Your site preview for commit ec2f77d is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13276-ec2f77d0.s3-website.us-west-2.amazonaws.com. |
In pulumi/pulumi#17673 and pulumi/pulumi#17697 we introduced a new optional configure method that has access to the stack configuration.
Wait for the next Pulumi release before merging this