Remove defaultable provider-ci arguments #1144
Merged
+5
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use values from the config instead of hard coding them
- `name` defaults to `{config.repository}` or `{config.organization}/pulumi-{config.provider}`
- `template` defaults to `{config.template}` or otherwise "bridged-provider"
- `config` defaults to `.ci-mgmt.yaml` so only specify in the update-workflows job where it's checked out into a different directory
- `out` defaults to `.` so only specify in the update-workflows job where it's checked out into a different directory
VenelinMartinov
approved these changes
Nov 14, 2024
iwahbe
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while testing #1143 that the generated PR ignored the repo's configured template and changed it.
--namedefaults to{config.repository}or{config.organization}/pulumi-{config.provider}--templatedefaults to{config.template}or otherwise "bridged-provider"--configdefaults to.ci-mgmt.yamlso only specify in the update-workflows job where it's checked out into a different directory--outdefaults to.so only specify in the update-workflows job where it's checked out into a different directory