Remove ambiguity in all text movement method names… #1042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of the form
(select|delete|cut|move)To(Beginning|End)OfLine
.Also add most permutations of the form
(select|delete|cut|move)To(Beginning|End)Of(Screen|Buffer)Line
.The ambiguous names are the ones that do not specify whether they operate on buffer coordinates or screen coordinates, and their behavior is inconsistent as a result. The behavior of each existing ambiguous method is preserved; the old method names are now aliases for the new ones.
This is a work in progress; the same work should be done in aliasing the respective command names that map to the old methods, plus creating new command names for the new methods.
Fixes #1041 — or at least I imagine it will once it's out of draft.
This is meant to be a collaboration, which is why I've created it on the
pulsar-edit
source. My goal here is not to forget the work of #810; it's as follows:onDidChangeCursorPosition
callback event property on deleting characters #810. We'll know we've done it right if all the tests keep passing.