-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pulp_openapi_generator_ref #906
base: main
Are you sure you want to change the base?
Conversation
@@ -52,6 +52,7 @@ DEFAULT_SETTINGS = { | |||
"pulp_env_azure": {}, | |||
"pulp_env_gcp": {}, | |||
"pulp_env_s3": {}, | |||
"pulp_openapi_generator_ref": None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we want to go about updating this?
Shall we try to keep it floating on latest main, or find the latest available tag, and only pin it down once we branch of a release branch?
Providing a default tag here will not really help updating it in the plugins, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the floating on main and then pin once we branch a release branch. Sounds reasonable and straight-forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we have a problem: After using the default branch on "main", this would pin the release branch to a probably older commit. That does not seem quite right, no?
a480913
to
7a2ce34
Compare
Now I wonder if it's a good idea to let the plugin decide on the template version. |
No description provided.