Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing missing exception when signature expired and change submodule from git to https git #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vicding-mi
Copy link

This PR fixes 2 issues I found when using flask-oidc pack.

  1. When the token expires, it raise an exception of type SignatureExpired, this exception class is in the package but not imported.
  2. when installing flask-oidc from GitHub using pip -r requirements.txt, it gives an error while cloning the submodule. Changed the protocol of submodule from git to https solves this issue.

The second issue only occurs when installing directly from GitHub. And users need the master branch on GitHub as it fixes issues which block usual auth action and always return 401 Not Authorised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant