Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toolbar use flex #311

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make toolbar use flex #311

wants to merge 1 commit into from

Conversation

erayalkis
Copy link

This issue makes the toolbar use flex to center the elements to improve user experience and make it easier to maintain, since flex makes it super easy to mess around with the design.

@welcome
Copy link

welcome bot commented Apr 2, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Apr 2, 2022

@cesswairimu
Copy link

Hi @erayalkis, thanks for working on this. Was there an issue for this? If so, kindly link us to it. Also please add some screenshots of the before and after to see the changes. Thanks

@erayalkis
Copy link
Author

My bad, I knew I was forgetting something !!
There wasn't any specific issue to link, I saw that people were talking about redesign ideas and I thought that switching to flex for the toolbar would make things easier to update and maintain. I'll attach the screenshots now, let me know if I need to do anything else!

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants