Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML with separate gradient steps #587

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ML with separate gradient steps #587

wants to merge 1 commit into from

Conversation

jfowkes
Copy link
Collaborator

@jfowkes jfowkes commented Nov 14, 2024

This PR adds the ML with separate gradient steps for probe and object reconstruction engine by @Letizia97 to custom.

Testing has shown that this gives marginally better reconstruction errors than ML at the expense of more computation (as the linesearch step size computation is performed for both probe and object necessitating an extra loop over the data).

Testing comparison on the moonflower example:

ML: Iteration # 300/300 ::  Photons 6.86e+01
MLSeparateGrads: Iteration # 300/300 :: Photons 2.03e+01

Testing on the small nanogold example:

ML: Iteration # 100/100 :: Photons 2.21e+02
MLSeparateGrads: Iteration # 100/100 :: Photons 1.71e+02

This is WIP, some things that need doing:

  • Subclass ML instead of writing most of the ML class again
  • Fix probe_update_start
  • Implement all poly_line_coeffs
  • Add GPU support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant