if refined positions are saved, they are also saved to dump files #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kahntm thanks for putting this PR, could you please rebase your commit on top of |
kahntm
force-pushed
the
position_refine_saving
branch
from
0df6030
to
b7b9b09
Compare
|
rebased the commit and changed the target in the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When position correction is used within an engine, up to now, the refined positions were only saved in the last/reconstruction file written by that engine. As it can be interesting to track the refinement process of the scan positions over the iterations, it would be nice to also have the possibility to save the refined positions to the dump files.
The changes to ptypy/core/ptycho.py accomplish just this. Once the record_positions parameter is set, dump files also get filled with the positions. By default this parameter is still set to False. So it is a conscious decision by the user to have the positions saved.