Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L-BFGS reconstruction engine #485

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

Conversation

jfowkes
Copy link
Collaborator

@jfowkes jfowkes commented Mar 17, 2023

Resurrecting #400 as GitHub broke the original PR.

Add Limited-memory BFGS reconstruction engine to as an alternative to ML.

Caveats:

  • L-BFGS does not support the object smoothing preconditioner for technical reasons (this would require the ability to invert the Gaussian filter, i.e. exactly de-blur and this is known to be impossible). However probe preconditioning (i.e. probe-object scaling) is supported and this is enough to reconstruct on the moonflower example with a lower error than ML.

@jfowkes jfowkes marked this pull request as ready for review March 17, 2023 08:22
@jfowkes
Copy link
Collaborator Author

jfowkes commented Mar 17, 2023

@daurer this L-BFGS pull request is now ready for review and potential merge.

@daurer
Copy link
Contributor

daurer commented Feb 6, 2024

Needs a CuPy engine before it can be merged. @ptim0626 maybe something for you?

@ptim0626
Copy link
Contributor

A quick comment, the tolerance for LBFGS's tests is increased as it is very likely the discrepancy is a result of numerical instability instead of the problem of implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants