Declaration is_const() returns true if declared with specifier constexpr
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finger563
changed the title
const if declared with constexpr
finger563
changed the title
const if declared with constexprconst if declared with constexpr
finger563
changed the title
const if declared with constexpris_const() returns true if declared with specifier constexpr
|
Hi William, Thanks a lot, this is perfect, and also thanks for adding a test. PS: I saw that you merged your PR esp-cpp/espp#291 . Congrats! Are you happy with the result? Cheers |
|
Hey Pascal, Thanks! And it's definitely a huge improvement over manually writing the binding code, even if I did have to refactor the code heavily to support parsing and generation. Been using it to make some nice python tooling and interfaces for another project which uses espp which has been great. Definitely looking forward to working through the two open issues so that there aren't any manual modifications required after generating the bindings 🚀 Thanks again for putting this project together, its a huge step up in development! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated srcmlcpp to check for
constexpras well asconstwhen determining if a declarationis_const().Added test as well.
Closes #16