fix: remove special handling for ^C stop command
#5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewriting the ^C into a default stop action causes docker to run the default stop action. It will run whatever is specified by STOPSIGNAL, or SIGTERM by default. This change allows wings to received the full data and issue the correct signal.
matthewpi
approved these changes
Jun 29, 2024
matthewpi
changed the title
^C stop command
matthewpi
pushed a commit
to pterodactyl/wings
that referenced
this pull request
Jun 29, 2024
dannyhpy
pushed a commit
to dannyhpy/pterodactyl-wings
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewriting the ^C into a default stop action causes docker to run the default stop action. It will run whatever is specified by STOPSIGNAL (specified in the image Dockerfile), or SIGTERM by default.
This change allows wings to received the full data and issue the correct signal.