Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept all possible private key encoding types (base64, hex, wif) #8

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

pshenmic
Copy link
Owner

Issue

We had only WIF encoding format for a private key, but user could have one in HEX encoded, and even Base64. It should be possible use any of them in the private key file transparently for the user.

Things done

  • Introduced new required command flag network
  • Added a decoding function that tries to validate and load private key from any of known encoding types
  • Corrected few flags documentation

@pshenmic pshenmic self-assigned this Oct 20, 2024
@pshenmic pshenmic merged commit 6bba5f3 into master Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant