Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PrivateSend in the wallet #3

Merged
merged 30 commits into from
Jan 29, 2024
Merged

Fix PrivateSend in the wallet #3

merged 30 commits into from
Jan 29, 2024

Conversation

pshenmic
Copy link
Owner

@pshenmic pshenmic commented Jan 5, 2024

Issue

PrivateSend feature is broken in Electrum Dash due a lot of upgrades have happened in the Dash network. The last used P2P protocol in the electrum is from Dash v15, while it's already v20 in the network around. There were a lot of hard forks that has a lot of protocol changes and message changes. This PR brings CoinJoin back to work in the Electrum Dash

#6

Things done

  • Upgraded wine to 9.0.0.0
  • Replaced bls_py with blspy to reflect BLS Basic scheme upgrade
  • Updated Dash P2P protocol to 70230 (Dash Core v20)
  • Updated list of Sporks
  • Updated DashSMLEntry structure
  • Updated DashMNListDiffMsg structure
  • Updated DashDssuMsg message
  • Updated DashDstxMsg message
  • Update DashDsqMsg message
  • Replace masternodeOutpoint with protxHash in the CoinJoin sessions
  • Added DashQuorumsCLSigObject structure (from the mnlistdiff)
  • Added bls-signature DLL build for windows
  • Added blspy_wrapper that loads blspy either from pip or shared library

@pshenmic pshenmic marked this pull request as draft January 5, 2024 16:38
@pshenmic pshenmic marked this pull request as ready for review January 17, 2024 21:12
@pshenmic pshenmic merged commit 43985ee into develop Jan 29, 2024
7 of 9 checks passed
@pshenmic pshenmic deleted the fix/private-send branch January 29, 2024 23:48
@pshenmic pshenmic mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant