-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no chunked attr #151
Open
elnuno
wants to merge
8
commits into
psf:master
Choose a base branch
from
elnuno:fix_no_chunked_attr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix no chunked attr #151
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2c6f027
Allow sorting query parameters. Gives a nice increase in cache hits f…
elnuno 43bd91e
Some tests. Probably worth pruning.
elnuno cf1debb
Add a section about query sorting to the tips doc.
elnuno 861be44
Merge remote-tracking branch 'upstream/master'
elnuno 60f00bd
Trivial fix and a test (for old requests versions) for #137.
elnuno 8cf339e
Revert "Allow sorting query parameters. Gives a nice increase in cach…
elnuno 4e76780
Revert "Some tests. Probably worth pruning."
elnuno cc4a5b8
Revert "Add a section about query sorting to the tips doc."
elnuno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
import pytest | ||
|
||
|
||
from cachecontrol import CacheControl | ||
from cachecontrol import CacheControl, CacheControlAdapter | ||
from cachecontrol.caches import FileCache | ||
from cachecontrol.filewrapper import CallbackFileWrapper | ||
from requests import Session | ||
|
@@ -29,3 +29,18 @@ def test_getattr_during_gc(): | |
vars(s).clear() # gc does this. | ||
with pytest.raises(AttributeError): | ||
s.x | ||
|
||
|
||
def test_handle_no_chunked_attr(): | ||
|
||
class NoChunked(CacheControlAdapter): | ||
def build_response(self, request, response, from_cache=False, | ||
cacheable_methods=None): | ||
if hasattr(response, 'chunked'): | ||
pytest.skip('Requests is new enough, test makes no sense.') | ||
# delattr(response, 'chunked') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you remove this comment? |
||
return super().build_response(request, response, from_cache, | ||
cacheable_methods) | ||
sess = Session() | ||
sess.mount('http://', NoChunked()) | ||
sess.get('http://httpbin.org/cache/60') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to assert something here! :) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might reword this as
Requests version supports chucked. Skipping this test.