reorganizing p2p and backfill service registration for consistency #14640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
reviewed
Nov 18, 2024
kasey
reviewed
Nov 18, 2024
beacon-chain/node/node.go
Outdated
| @@ -1136,6 +1130,16 @@ func (b *BeaconNode) registerBuilderService(cliCtx *cli.Context) error { | |||
| return b.services.RegisterService(svc) | |||
| } | |||
|
|
|||
| func (b *BeaconNode) RegisterBackFillService(cliCtx *cli.Context, bfs *backfill.Store) error { | |||
There was a problem hiding this comment.
"Backfill" is one word. This should be written RegisterBackfillService.
kasey
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
P2P and backfill service registrations aren't starting in the right spots, these services are not started at the time of registration so they should probably be moved.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements