Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add peer format on flags & Refactor parsing address #14615

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add peer format on flags & Refactor parsing address #14615

wants to merge 6 commits into from

Conversation

syjn99
Copy link
Contributor

@syjn99 syjn99 commented Nov 4, 2024 •
edited
Loading

What type of PR is this?

Feature & Refactor

What does this PR do? Why is it needed?

  • CLI users will be aware of which type for p2p addresses, especially for --peer and --bootstrap-node flags.
  • There are some redundancies in parsing and converting p2p addresses. (e.g. parsePeersEnr, PeersFromStringAddrs, connectWithAllTrustedPeers, connectWithAllPeers...) I refactored those util functions for more readability.

Which issues(s) does this PR fix?

Fixes #14166 & #14606

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@syjn99 syjn99 marked this pull request as ready for review November 4, 2024 15:07
@syjn99 syjn99 requested a review from a team as a code owner November 4, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

what is the format for the --peer parameter for the beacon-chain ?
1 participant
@syjn99