Use New Cache Key For Unaggregated Attestations #14590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
reviewed
Oct 30, 2024
| @@ -328,3 +326,15 @@ func (s *Service) hasBlockAndState(ctx context.Context, blockRoot [32]byte) bool | |||
| hasState := hasStateSummary || s.cfg.beaconDB.HasState(ctx, blockRoot) | |||
| return hasState && s.cfg.chain.HasBlock(ctx, blockRoot) | |||
| } | |||
|
|
|||
| func seenAttCacheKey(slot primitives.Slot, committeeID primitives.CommitteeIndex, aggregationBits []byte) string { | |||
| totalLen := 8 + 8 + len(aggregationBits) | |||
There was a problem hiding this comment.
It might be helpful to add an explanation of what these numbers represent for anyone unfamiliar with the code. Otherwise they just seem like magic numbers
| @@ -328,3 +326,15 @@ func (s *Service) hasBlockAndState(ctx context.Context, blockRoot [32]byte) bool | |||
| hasState := hasStateSummary || s.cfg.beaconDB.HasState(ctx, blockRoot) | |||
| return hasState && s.cfg.chain.HasBlock(ctx, blockRoot) | |||
| } | |||
|
|
|||
| func seenAttCacheKey(slot primitives.Slot, committeeID primitives.CommitteeIndex, aggregationBits []byte) string { | |||
There was a problem hiding this comment.
A benchmark test would be nice so that we can see the before/after improvements.
There was a problem hiding this comment.
Benchmark between old and new implementations:
goos: linux
goarch: amd64
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
BenchmarkCacheKeyImplementations
BenchmarkCacheKeyImplementations/Old_Cache_Key_Implementation
BenchmarkCacheKeyImplementations/Old_Cache_Key_Implementation-8 7620234 169.0 ns/op 280 B/op 4 allocs/op
BenchmarkCacheKeyImplementations/New_Cache_Key_Implementation
BenchmarkCacheKeyImplementations/New_Cache_Key_Implementation-8 35468606 31.01 ns/op 24 B/op 1 allocs/op
|
|
||
| // Avoid copying to reduce allocation when casting. It is guaranteed to be immutable as the | ||
| // slice is only created in this method and isn't accessed/returned anywhere else. | ||
| return unsafe.String(&key[0], len(key)) // #nosec G103 |
There was a problem hiding this comment.
Can you use the same bytesutil.UnsafeCastToString from #14591 ?
There was a problem hiding this comment.
Will do after that PR is merged in and remove this
saolyn
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimization
What does this PR do? Why is it needed?
This optimizes the cache key computation for specific attestation and reduces the amount of memory allocated. In certain networks, this is a high traffic path which leads to unnecessary allocation of memory.
Benchmarks of New Implementation:
Which issues(s) does this PR fix?
N.A
Other notes for review
Acknowledgements