Receive ptc message #14394
Merged
Receive ptc message #14394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Aug 28, 2024
| @@ -22,6 +22,7 @@ import ( | |||
| "github.com/prysmaticlabs/prysm/v5/encoding/bytesutil" | |||
| "github.com/prysmaticlabs/prysm/v5/monitoring/tracing" | |||
| ethpbv1 "github.com/prysmaticlabs/prysm/v5/proto/eth/v1" | |||
| eth "github.com/prysmaticlabs/prysm/v5/proto/prysm/v1alpha1" | |||
| ethpb "github.com/prysmaticlabs/prysm/v5/proto/prysm/v1alpha1" | |||
There was a problem hiding this comment.
why is same package imported twice under different names?
Comment on lines
32
to
33
| eth "github.com/prysmaticlabs/prysm/v5/proto/prysm/v1alpha1" | ||
| ethpb "github.com/prysmaticlabs/prysm/v5/proto/prysm/v1alpha1" |
There was a problem hiding this comment.
same here, duplicated imports
shyam-patel-kira
approved these changes
Aug 28, 2024
terencechain
approved these changes
Aug 28, 2024
potuz
added a commit
that referenced
this pull request
Aug 29, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Sep 13, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Sep 18, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Sep 26, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Oct 7, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Oct 14, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Oct 16, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Oct 22, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Oct 28, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Nov 1, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
potuz
added a commit
that referenced
this pull request
Nov 4, 2024
* Handle incoming ptc attestation messages in the chain package * fix double import * remove unused error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the handling of PTC messages from the sync package to the chain package so that it can be called from rpc