Fix setup.py and improve support for pip #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* LIBDEST and LIBPYTHON variables seem to exist on different platforms. Check both? * Fix error in version number making of setup.py (%d when value is string), but superceeded by next change. * Change version to single string following PEP-0440 * Bump micro version for new packaging. Would be 1.9c, but now 1.9.3. * Move version info into a __version_info__.py file so it can be imported independently of gerbmerge.gerbmerge. This allows dependency resolution. * Add requirement for simpleparse so it is installed automatically. * Add a __main__ for use with `python -m`. This makes it easy to use from a pip installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @kylemanna on e574deb the version number 9b breaks the current setup.py script. I also had some trouble with the LIBPYTHON environmental variable on my OS X/homebrew python setup. I took the opportunity to fix the setup.py and make some small updates to make it more usable with
pip. This should make it easier to install/uninstall gerbmerge and make it ready to upload to a package index. I have only tested this in my OS X environment (although I think the changes are safe across platforms), so I would appreciate relevant feedback.