-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write integration tests and resolve issues found #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: fix workflow file syntax problem
docs: fix badge link in README.md
docs: add a optimization todo
Add test image to docker-compose file Update testing documentation to reflect the changes
test: add unit test for canonicalization.rs
oxr463
approved these changes
Jul 26, 2021
@KB5201314 should we wait to merge until #42 and #43 are fixed? |
No, they're not that important, I think we can put them aside for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce an integration test module for proot-rs. #33
We use
bats-core
to run the integration tests. All the files are placed in thetests/
directory and README.md is included.The current integration test includes these sections:
cli
: Test the command-line interface ofproot-rs
bind
: Check if path bind is working correctlycwd
: Testing the emulation of cwdmulti-tracee
: Testing for the multi-tracee caseapplets
: Test some common applets (basically those listed here) to see if they work properlyIt should be noted that there are still 14 applets that have not been tested for some reason. They are
chroot
,df
,dmesg
,hostname
,login
,mount
,passwd
,reboot
,su
,top
,umount
,vi
,watch
,who
. The reasons can be found in this tableexecve
: Test the ability to run executable filesevent
: Tests related to proot event loopsIn the process of writing tests we found several bugs:
Four of the more serious ones have been fixed, the remaining two are less affected and have not been fixed yet