Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write integration tests and resolve issues found #45

Merged
merged 17 commits into from
Jul 27, 2021
Merged

Conversation

imlk0
Copy link
Collaborator

@imlk0 imlk0 commented Jul 26, 2021

This PR aims to introduce an integration test module for proot-rs. #33

We use bats-core to run the integration tests. All the files are placed in the tests/ directory and README.md is included.

The current integration test includes these sections:

  • cli: Test the command-line interface of proot-rs
  • bind: Check if path bind is working correctly
  • cwd: Testing the emulation of cwd
  • multi-tracee: Testing for the multi-tracee case
  • applets: Test some common applets (basically those listed here) to see if they work properly
    It should be noted that there are still 14 applets that have not been tested for some reason. They are chroot,df,dmesg,hostname,login,mount,passwd,reboot,su,top,umount,vi,watch,who. The reasons can be found in this table
  • execve: Test the ability to run executable files
  • event: Tests related to proot event loops

In the process of writing tests we found several bugs:

Four of the more serious ones have been fixed, the remaining two are less affected and have not been fixed yet

@imlk0 imlk0 added this to the v0.0.1 milestone Jul 26, 2021
@imlk0 imlk0 requested a review from oxr463 July 26, 2021 09:08
@imlk0 imlk0 self-assigned this Jul 26, 2021
@oxr463
Copy link
Contributor

oxr463 commented Jul 26, 2021

@KB5201314 should we wait to merge until #42 and #43 are fixed?

@imlk0
Copy link
Collaborator Author

imlk0 commented Jul 27, 2021

@KB5201314 should we wait to merge until #42 and #43 are fixed?

No, they're not that important, I think we can put them aside for now.

@oxr463 oxr463 merged commit 644457f into master Jul 27, 2021
@oxr463 oxr463 deleted the integration-tests branch July 27, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants