Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reporting Feature with SDK Lib #5806

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

alban-stourbe-wmx
Copy link
Contributor

Proposed changes

Today, the SDK lib does not handle Reporting.
I have created a new option with the SDK called WithExportReportingOptions allowing to set up theses options.
Then, to modify the code as little as possible, I've made the runner function createReportingOptions public, so that it can be used from the SDK lib.
I don't think this modification will create any security concerns or call into question the architecture of the project. However, I'm open to any objections.

I've made some tests and it works ! :)

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@GeorginaReeder
Copy link

Thanks for your contribution @alban-stourbe-wmx !

@alban-stourbe-wmx
Copy link
Contributor Author

alban-stourbe-wmx commented Nov 12, 2024

@dwisiswant0 do i need also to open an issue ? Thanks by advance

@dwisiswant0
Copy link
Member

@dwisiswant0 do i need also to open an issue ? Thanks by advance

Yes.

@alban-stourbe-wmx
Copy link
Contributor Author

alban-stourbe-wmx commented Nov 13, 2024

@dwisiswant0 do i need also to open an issue ? Thanks by advance

Yes.

Hello, the issue is created, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants