Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix findGlobPathMatches #5515

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix findGlobPathMatches #5515

wants to merge 2 commits into from

Conversation

zrquan
Copy link
Contributor

@zrquan zrquan commented Aug 12, 2024

Proposed changes

fix #5420

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@zrquan
Copy link
Contributor Author

zrquan commented Aug 12, 2024

There are still issues with displaying the templates, but I'm not yet sure how to fix it.

image

@zrquan
Copy link
Contributor Author

zrquan commented Aug 13, 2024

There are still issues with displaying the templates

One possible solution is to run BackwardsCompatiblePaths on all paths before returning from GetTemplatesPath. I'm not sure if there might be any side effects, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwisiswant0 dwisiswant0 Awaiting requested review from dwisiswant0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template Path containing a Wildcard is not working anymore
1 participant
@zrquan