[NCL-8675] Add latest Brew Push column to Group Build Builds list #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Problems:
|
matedo1
requested changes
Apr 25, 2024
| * | ||
| * @param requestConfig - Axios based request config | ||
| */ | ||
| export const getBuildsWithBrewPush = async ( |
There was a problem hiding this comment.
dead code, it should be removed until it's really need
| * | ||
| * @param requestConfig - Axios based request config | ||
| */ | ||
| export const getBuildsWithBrewPush = async ( |
There was a problem hiding this comment.
Current implementation is blocking whole lits just because of one column, even if some users / use-cases don't need that column at all. Anyway soon we will be implementing the similar functionality on other top-level pages, where blocking way would be very limiting and probably not possible due to performance issues.
Possible solution could be creating separated latestBrewPush component managing its state independently?
I understand there can be some other technical difficulties, if so, feel free to reach me directly and we can investigate other possible solutions together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.