Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCL-7219] Implement Artifact Quality Revisions list #263

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[NCL-7219] Implement Artifact Quality Revisions list #263

merged 1 commit into from
Aug 1, 2023

Conversation

patrikk0123
Copy link
Contributor

No description provided.

@patrikk0123 patrikk0123 requested a review from DnsZhou July 27, 2023 08:45
@patrikk0123 patrikk0123 force-pushed the ncl7219-artifactRevisionsPage branch from 931d239 to 1d42175 Compare July 31, 2023 14:01
DnsZhou
DnsZhou approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@DnsZhou DnsZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good from my local except the issue with backend, if this is a known issue with jira then feel free to proceed, it should be fixed automactially when endpoint fixes.

src/common/artifactQualityRevisionEntityAttributes.ts Outdated Show resolved Hide resolved
@patrikk0123 patrikk0123 force-pushed the ncl7219-artifactRevisionsPage branch from 1d42175 to 116516c Compare August 1, 2023 08:25
@patrikk0123 patrikk0123 force-pushed the ncl7219-artifactRevisionsPage branch from 116516c to 52592f9 Compare August 1, 2023 08:37
@patrikk0123 patrikk0123 merged commit 380fcc3 into project-ncl:main Aug 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnsZhou DnsZhou DnsZhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrikk0123 @DnsZhou