[NCL-7204] Implement BuildConfigList page #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matedo1
reviewed
Jul 26, 2023
matedo1
reviewed
Jul 26, 2023
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
from
6df1761
to
68471ff
Compare
DnsZhou
changed the title
|
Clean build has failed, it is most likely caused by upstream projects. Checking in progress... |
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
from
d3843f4
to
3f362e5
Compare
patrikk0123
reviewed
Jul 31, 2023
patrikk0123
reviewed
Jul 31, 2023
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
from
32a312b
to
6738538
Compare
patrikk0123
approved these changes
Aug 1, 2023
matedo1
requested changes
Aug 1, 2023
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
4 times, most recently
from
4ba6235
to
9e49aab
Compare
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
from
549a444
to
2bc5d85
Compare
matedo1
requested changes
Aug 2, 2023
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
2 times, most recently
from
8b48d23
to
8088363
Compare
matedo1
requested changes
Aug 3, 2023
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
2 times, most recently
from
0330f17
to
ac9c904
Compare
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
from
ac9c904
to
a7bfa11
Compare
matedo1
requested changes
Aug 4, 2023
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
from
a7bfa11
to
7f48f39
Compare
matedo1
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
There is last one optional proposal pending, but it's approved.
Entity Attributes were already integrated into Sorting, rebase your PR on top of it and apply required changes, see for example:
- https://github.com/project-ncl/pnc-web-ui-react/pull/273/files#diff-9be327f02fe34e9110d5a73d2f501fd115e816052eb6461d21d8e36160a7abff
- https://github.com/project-ncl/pnc-web-ui-react/pull/273/files#diff-bbedf30c67e0ca2f1d9846bf98525f1294244dd631536053e131d344787c0dc3
Thanks!
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
from
7f48f39
to
5d37216
Compare
|
Hi @matedo1 , I updated the code to align the latest upstream, see the latest commit and feel free to approve it if it makes sense. Thanks! |
DnsZhou
force-pushed
the
ncl7204-buildConfigListPage
branch
from
1c2ef9a
to
d9f0ada
Compare
matedo1
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.