Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #17

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

jfacorro
Copy link

@jfacorro jfacorro commented Jul 1, 2018

  • Uses maps instead of dict:dict().
  • Avoid doing list processing when handling trace messages.
  • Remove unnecessary list processing when building the iolist().
  • Consolidate multiplications of 1000s into constants.
  • Run the tracing for a maximum of DEFAULT_TIMEOUT to avoid getting a huge state in the tracer process (this can be modified so it can be provided as an option).
  • Avoid having to generate multiple entries in the output by producing the format flamegraph.pl expects.

The result from this improvements is that eflame is now able to return a result for simple benchmarks and it doesn't timeout when it's waiting for the response of dump_bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant