fix: add to immutable trie returns original trie if no changes made #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
approved these changes
Oct 18, 2023
Comment on lines
+218
to
+225
| for _, kk := range sampleKeySet.Keys { | ||
| next, err := Add(tr, kk, nil) | ||
| require.NoError(t, err) | ||
| // trie has not been changed | ||
| require.Same(t, tr, next) | ||
| } | ||
| require.Equal(t, len(sampleKeySet.Keys), tr.Size()) | ||
|
|
There was a problem hiding this comment.
Does it make sense to assert the counter-case as well? Like, if I added the same key with different data that the tries are NotSame? Not sure if this is covered by another test already.
There was a problem hiding this comment.
Yes, I can add that test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TrieRT relies on this property to detect whether a node was added to the routing table or not. The bug doesn't cause any adverse effects to the TrieRT but makes it less efficient.