This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 272
Feat/#454 implement ErrorOutOfGasCreate error state #481
Merged
KimiWu123
merged 17 commits into
master
from
feat/#454-Implement-ErrorOutOfGasCREATE2-error-state
Aug 30, 2023
Merged
Feat/#454 implement ErrorOutOfGasCreate error state #481
KimiWu123
merged 17 commits into
master
from
feat/#454-Implement-ErrorOutOfGasCREATE2-error-state
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimiWu123
force-pushed
the
feat/#454-Implement-ErrorOutOfGasCREATE2-error-state
branch
from
August 4, 2023 02:40
644909f
to
af8d6e0
Compare
KimiWu123
force-pushed
the
feat/#454-Implement-ErrorOutOfGasCREATE2-error-state
branch
from
August 8, 2023 06:29
e3912a3
to
28e132f
Compare
ChihChengLiang
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the feedback is addressed.
src/zkevm_specs/evm_circuit/execution/error_gas_uint_overflow.py
Outdated
Show resolved
Hide resolved
src/zkevm_specs/evm_circuit/execution/error_gas_uint_overflow.py
Outdated
Show resolved
Hide resolved
Comment on lines
+28
to
+29
offset_word = instruction.stack_lookup(RW.Read, 1) | ||
size_word = instruction.stack_lookup(RW.Read, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
No change is required here. But we discussed where we should use stack_pop or stack_lookup here.
stack_pop modifies the stack, and stack_lookup has no side-effects.
We think it's okay to use either one since Stack will reset after the error state.
rrtoledo
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
KimiWu123
deleted the
feat/#454-Implement-ErrorOutOfGasCREATE2-error-state
branch
September 6, 2023 06:16
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #454 and #459
EIP-3860 includes
49152
2 * len(ceil(init_code/32))
This PR includes
CREATE/2
oog fromerror_oog_dynamic_memory_expansion.py
toerror_oog_create.py
create.py
add extra gas cost for init code.begin_tx.py
add extra gas cost for init codeerror_oog_create.py
handles errors of oog and max size of init code (see Rules 1 and 3).error_gas_uint_overflow.py
handles extra gas required for init code