Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Conversation

ashWhiteHat
Copy link
Contributor

@ashWhiteHat ashWhiteHat commented Feb 10, 2023

Close #376
Part of #364

I did following things in this PR.

  1. give start, memory and stack, storage constraints to serial number
  2. update rw table columns
  3. rename bytecode and tx to bytecode_circuit and tx_circuit
  4. update mpt proof according to circuits

I would appreciate it if you could confirm.
Thank you!

@ashWhiteHat ashWhiteHat mentioned this pull request Feb 10, 2023
12 tasks
@ashWhiteHat ashWhiteHat changed the title [WIP] start, memory, stack and storage, rw table synchronization start, memory, stack and storage, rw table synchronization Feb 20, 2023
@ashWhiteHat ashWhiteHat marked this pull request as ready for review February 20, 2023 08:29
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 nits. The rest looks good to me!

src/zkevm_specs/state_circuit.py Show resolved Hide resolved
src/zkevm_specs/state_circuit.py Outdated Show resolved Hide resolved
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good! Thanks for collecting the enumerated constraints into the markdown file :D

I've added a request about the update applied to MPTProofType/ProofType, please take a look!

src/zkevm_specs/evm/table.py Outdated Show resolved Hide resolved
…f github.com:NoCtrlZ/zkevm-specs into feature/sync-start-memory-stack-and-storage-rw-table
@ashWhiteHat
Copy link
Contributor Author

Hi @ed255
Thank you for the review!
I totally mistook the reference.
I modified the MPTProof names.

I would appreciate it if you could review.
Thank you.

Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashWhiteHat ashWhiteHat merged commit ec5246f into privacy-scaling-explorations:master Feb 28, 2023
@CPerezz
Copy link
Member

CPerezz commented Feb 28, 2023

Awesome job @ashWhiteHat !!!!!

ashWhiteHat added a commit to privacy-scaling-explorations/zkevm-circuits that referenced this pull request Mar 11, 2023
I synchronized memory and mpt proof according to spec synchronization.
privacy-scaling-explorations/zkevm-specs#385

I did following things.

- add [2.1
constraint](https://github.com/privacy-scaling-explorations/zkevm-specs/blob/master/specs/state-proof.md#memory)
- update ProofType

I would appreciate it if you could confirm.
Thank you!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RW table is out-of-sync with the circuits impl
3 participants