-
Notifications
You must be signed in to change notification settings - Fork 272
start, memory, stack and storage, rw table synchronization #385
start, memory, stack and storage, rw table synchronization #385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 nits. The rest looks good to me!
Co-authored-by: Carlos Pérez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good! Thanks for collecting the enumerated constraints into the markdown file :D
I've added a request about the update applied to MPTProofType
/ProofType
, please take a look!
…f github.com:NoCtrlZ/zkevm-specs into feature/sync-start-memory-stack-and-storage-rw-table
Hi @ed255 I would appreciate it if you could review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Awesome job @ashWhiteHat !!!!! |
I synchronized memory and mpt proof according to spec synchronization. privacy-scaling-explorations/zkevm-specs#385 I did following things. - add [2.1 constraint](https://github.com/privacy-scaling-explorations/zkevm-specs/blob/master/specs/state-proof.md#memory) - update ProofType I would appreciate it if you could confirm. Thank you!
Close #376
Part of #364
I did following things in this PR.
start
,memory
andstack
,storage
constraints to serial numberbytecode
andtx
tobytecode_circuit
andtx_circuit
circuits
I would appreciate it if you could confirm.
Thank you!