Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Add cumulative gas check in EndBlock #337

Merged
merged 6 commits into from
Dec 15, 2022

Conversation

davidnevadoc
Copy link
Contributor

Close #207

@davidnevadoc davidnevadoc marked this pull request as ready for review December 13, 2022 12:51
src/zkevm_specs/evm/execution/end_block.py Show resolved Hide resolved
src/zkevm_specs/evm/execution/end_block.py Outdated Show resolved Hide resolved
src/zkevm_specs/evm/execution/end_block.py Outdated Show resolved Hide resolved
src/zkevm_specs/evm/execution/end_block.py Outdated Show resolved Hide resolved
src/zkevm_specs/evm/execution/end_block.py Outdated Show resolved Hide resolved
tests/evm/test_end_block.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! Got the similar thought as Edu's and left some further comments.

tests/evm/test_end_block.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidnevadoc davidnevadoc merged commit 85f9796 into master Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

constrain cumulativeGasUsed not exceed gas limit in block
3 participants