Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Identity (dataCopy) precompile #1628

Merged
merged 191 commits into from
Dec 12, 2023
Merged

Identity (dataCopy) precompile #1628

merged 191 commits into from
Dec 12, 2023

Conversation

darth-cy
Copy link
Contributor

Description

This is a follow-up PR for PR#1396 from @roynalnaruto. After merging in 1396's changes to a fresh fork, the branch is compared with Scroll's develop head to incorporate latest patterns on precompile-related development.

Issue Link

Aggregating precompile issue 924

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Design choices

See documentation

roynalnaruto and others added 30 commits May 8, 2023 11:30
@roynalnaruto
prerequisite for handling precompile gadgets
9f661a3
@roynalnaruto
identity gadget config
3381421
@roynalnaruto
copy table lookups for identity precompile
70259ca
@roynalnaruto
Merge branch 'main' into feat/precompile-identity
eac7209
@roynalnaruto
structure for verifying precompile call
6911fdc
@roynalnaruto
connect bus-mapping of precompile to callop
335c14b
@roynalnaruto
copy events for identity precompile
76cf3d2
@roynalnaruto
minor refactor
7a1ef55
@roynalnaruto
witness assignment
24de2d2
@roynalnaruto
Merge branch 'main' into feat/precompile-identity
5aefc1d
@roynalnaruto
err: debugging precomp identity
63572f2
@roynalnaruto
Merge branch 'main' into feat/precompile-identity
778ff12
@roynalnaruto
some fixes
07775fd
@roynalnaruto
wip debugging
6c6c8e1
@roynalnaruto
more fixes
d389a9f
@roynalnaruto
more fixes
4cc0780
@roynalnaruto
refactoring
86f0a41
@roynalnaruto
busmapping precompile call test failure fix
7d713f2
@roynalnaruto
fix order of operation (rw counter issue)
a2818b5
@roynalnaruto
more tests
3df95c2
@darth-cy
merge in rohit's changes
3818d8b
@darth-cy
add gas cost constants in evm_types using Scroll's main
8141d52
@darth-cy
correct typo and type mismatch
0597442
@darth-cy
correct call op dependencies in bus mapping
fac0570
@darth-cy
restore tests
334236a
@darth-cy
feature flag
a3587bc
@darth-cy
reconcile with head precompile execution
f0fe1a0
@darth-cy
reconcile bus mapping callop test pattern
77ed99f
@darth-cy
remove unnecessary import
1cd63ce
@darth-cy
allow common call ctx to throw err
68ca06c
ChihChengLiang
ChihChengLiang reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review.

bus-mapping/src/circuit_input_builder/input_state_ref.rs Outdated Show resolved Hide resolved
bus-mapping/src/circuit_input_builder/input_state_ref.rs Outdated Show resolved Hide resolved
bus-mapping/src/circuit_input_builder/input_state_ref.rs Outdated Show resolved Hide resolved
bus-mapping/src/circuit_input_builder/input_state_ref.rs Outdated Show resolved Hide resolved
bus-mapping/src/circuit_input_builder/input_state_ref.rs Outdated Show resolved Hide resolved
bus-mapping/src/circuit_input_builder/input_state_ref.rs Outdated Show resolved Hide resolved
bus-mapping/src/error.rs Outdated Show resolved Hide resolved
bus-mapping/src/evm/opcodes/callop.rs Outdated Show resolved Hide resolved
@ed255 ed255 mentioned this pull request Nov 30, 2023
Closed
@ChihChengLiang ChihChengLiang linked an issue Nov 30, 2023 that may be closed by this pull request
Integrate precompiles into callop privacy-scaling-explorations/zkevm-specs#498
Closed
@ChihChengLiang ChihChengLiang removed a link to an issue Nov 30, 2023
Integrate precompiles into callop privacy-scaling-explorations/zkevm-specs#498
Closed
ChihChengLiang
ChihChengLiang reviewed Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of review.
This should be my final round. The PR is mergeable after all the feedback is addressed.

bus-mapping/src/evm/opcodes/callop.rs Outdated Show resolved Hide resolved
bus-mapping/src/evm/opcodes/callop.rs Outdated Show resolved Hide resolved
bus-mapping/src/precompile.rs Show resolved Hide resolved
bus-mapping/src/precompile.rs Outdated Show resolved Hide resolved
ChihChengLiang
ChihChengLiang approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the Identity precompile feature

@ChihChengLiang ChihChengLiang added this pull request to the merge queue Dec 12, 2023
@lispc
Copy link
Collaborator

lispc commented Dec 12, 2023

Great!

Merged via the queue into privacy-scaling-explorations:main with commit fe9beeb Dec 12, 2023
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roynalnaruto roynalnaruto roynalnaruto approved these changes

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

Assignees
No one assigned
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-eth-types Issues related to the eth-types workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darth-cy @lispc @ChihChengLiang @roynalnaruto