Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code of conduct for modding and mapping #12210

Merged
merged 16 commits into from
Oct 17, 2024

Conversation

MChecaH
Copy link
Contributor

@MChecaH MChecaH commented Sep 24, 2024

First change of the suite of changes prepared to improve the Wiki's current modding resources.

This one is focused on simplifying, rewording, and improving the current Modding Code of Conduct article. The contents deleted will be moved to their respective articles, decluttering the CoC in turn.

The project is being tracked in the following Issue and the following osu! Discord server thread.

Note for later; The broken wiki link in Modding will need to be changed later by the new guide, once it is ready.

Self-check

  • The changes are tested against the contribution checklist
  • The changes are reviewed by the team working on the rework. Thread
  • The changes are reviewed by the team who will enforce them (Mainly NAT and map/mod GMTs). Thread

Copy link
Contributor

@Userlog2 Userlog2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more to say outside the comments I made.

Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last review for me

wiki/Rules/Code_of_conduct_for_modding_and_mapping/en.md Outdated Show resolved Hide resolved
wiki/Rules/Code_of_conduct_for_modding_and_mapping/en.md Outdated Show resolved Hide resolved
wiki/Rules/Code_of_conduct_for_modding_and_mapping/en.md Outdated Show resolved Hide resolved
wiki/Rules/Code_of_conduct_for_modding_and_mapping/en.md Outdated Show resolved Hide resolved
wiki/Rules/Code_of_conduct_for_modding_and_mapping/en.md Outdated Show resolved Hide resolved
wiki/Rules/Code_of_conduct_for_modding_and_mapping/en.md Outdated Show resolved Hide resolved
wiki/Rules/Code_of_conduct_for_modding_and_mapping/en.md Outdated Show resolved Hide resolved
wiki/Rules/Code_of_conduct_for_modding_and_mapping/en.md Outdated Show resolved Hide resolved
@cl8n
Copy link
Member

cl8n commented Oct 7, 2024

oh also it's not in the change set but I would remove "and general ranking criteria" from the intro... doesnt really make sense because the rules apply to different things, and it's just unnecessary for that sentence to work well

cl8n
cl8n previously approved these changes Oct 8, 2024
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval for article itself, but ci says some other links need to be adjusted

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 9, 2024
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with the expectation that the context in /Modding will be improved in a future PR)

@peppy peppy merged commit cc9edbc into ppy:master Oct 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants