Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add National Dutch Championship series to tournaments #12033

Merged
merged 14 commits into from
Sep 17, 2024
Merged

Conversation

MrHeliX
Copy link
Contributor

@MrHeliX MrHeliX commented Aug 24, 2024

Self-check

Copy link

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

wiki/Tournaments/NDC/2022/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/NDC/2022/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/NDC/2022/en.md Outdated Show resolved Hide resolved
Copy link
Contributor

@0x84f 0x84f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Walavouchey other than this i think this can go?

wiki/Tournaments/NDC/2022/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/NDC/2022/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/NDC/2022/en.md Outdated Show resolved Hide resolved
@0x84f
Copy link
Contributor

0x84f commented Sep 15, 2024

oh also i'd reduce the dimensions of the logo because right now its huge
image

wiki/Tournaments/NDC/2022/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/NDC/2022/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/NDC/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/NDC/2022/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/NDC/2023/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/NDC/2024/en.md Outdated Show resolved Hide resolved
@Joehuu Joehuu self-requested a review September 15, 2024 21:04
@Joehuu Joehuu changed the title Added National Dutch Championship series to tournaments Add National Dutch Championship series to tournaments Sep 15, 2024
Copy link
Member

@Joehuu Joehuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Joehuu
Copy link
Member

Joehuu commented Sep 17, 2024

Just going to merge this, so updates can happen in new PRs (with corrections if they are missed).

@Joehuu Joehuu merged commit 5367bd4 into ppy:master Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants