Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose SampleChannel in Sample if it is not disposed yet #6397

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Dispose SampleChannel in Sample if it is not disposed yet #6397

wants to merge 8 commits into from
+102 −5

Commits on Oct 25, 2024

  1. Remove IsAlive from SampleChannel to let childern define their own 

    This commit also adds one for SampleChannelVirtual.
It is needed to let childern use IsAlive from parent of SampleChannel.
    @hwsmm
    hwsmm committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    da1c2ec View commit details
    Browse the repository at this point in the history

  2. Fix wrong state of SampleChannelBass by adding userRequestedStop 

    Before this commit, calling Stop makes playing false, which in turn makes IsAlive false.
    @hwsmm
    hwsmm committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    343eff3 View commit details
    Browse the repository at this point in the history

  3. Add a test case 'TestAliveAfterStop'

    @hwsmm
    hwsmm committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7aed7c4 View commit details
    Browse the repository at this point in the history

  4. Check IsDisposed before setting flags in SampleChannelBass

    @hwsmm
    hwsmm committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    08e68bd View commit details
    Browse the repository at this point in the history

  5. Make AudioComponent IsDisposed public

    @hwsmm
    hwsmm committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ec07a21 View commit details
    Browse the repository at this point in the history

  6. Dispose SampleChannel if it is not disposed yet

    @hwsmm
    hwsmm committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    08ae2ef View commit details
    Browse the repository at this point in the history

  7. Handle disposal in TestDoesNotRestart and add TestChannelLifetime

    @hwsmm
    hwsmm committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9a28f89 View commit details
    Browse the repository at this point in the history

  8. Add comments for ItemAdded/Removed (suggestion from peppy)

    @hwsmm
    hwsmm committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    271c6b6 View commit details
    Browse the repository at this point in the history