Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 32 bit rotated screen #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pfyra
Copy link

@pfyra pfyra commented Dec 15, 2023

This PR makes 32 bpp work with 90 degree rotation. Other combinations should work as well, but I haven't tested anything else.

Not sure about BITS_PER_SAMPLE, but colors are a bit off if I keep it at 5.

@ponty
Copy link
Owner

ponty commented Dec 18, 2023

You can test the results so: (from README)

python3 -m pip install fabric vncdotool python-vagrant entrypoint2
python3 vfb.py

I added tests for 32 bit rotation I run the above test and I uploaded the results in my rot32 branch:

https://github.com/ponty/framebuffer-vncserver/tree/rot32#automatic-test

32 bit rotation seems to be OK, but the 16 bit became green.

@pfyra
Copy link
Author

pfyra commented Jan 11, 2024

Sorry for being slow...
I tried running the automated tests but unfortunately I get some vagrant errors.
However, I do believe that the change of BITS_PER_SAMPLE is the cause of the greeniness as the PIXEL_FB_TO_RFB macro shifts the blue value 16 bits to the left and if only 16 bits per pixel is used I guess the blue color will be missing completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants