Prevent writing artifacts to invalid location #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smidf
force-pushed
the
prevent-writing-artifacts-to-invalid-location
branch
from
b2a29e0
to
bd407de
Compare
If the value is dynamically obtained from an environment variable, an empty string is set for the non-existing variable. This change prevents writing the artifacts to an invalid / prohibited location.
smidf
force-pushed
the
prevent-writing-artifacts-to-invalid-location
branch
from
bd407de
to
5683ee0
Compare
|
@stephencelis, @mbrandonw Any feedback on this small fix, guys? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
SNAPSHOT_ARTIFACTSvalue is dynamically obtained from an environment variable, an empty string is set for the non-existing variable. This change prevents writing the artifacts to an invalid / prohibited location.