Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim Removal #31

Merged
merged 2 commits into from
May 14, 2024
Merged

Shim Removal #31

merged 2 commits into from
May 14, 2024

Conversation

Rspoon3
Copy link
Contributor

@Rspoon3 Rspoon3 commented May 9, 2024

Shims.swift is no longer needed since sleep(for:tolerance:) is now a native function.

@mbrandonw
Copy link
Member

Hi @Rspoon3, while it is true sleep(for:) has been officially released, this library still supports older versions of Swift where it is not supported. So if we are going to remove the shims then we should also update Package.swift to be Swift 5.7. Would you mind adding that to this PR?

@Rspoon3
Copy link
Contributor Author

Rspoon3 commented May 10, 2024

@mbrandonw Yeah not a problem! Should the availability checks also be removed now?

@mbrandonw
Copy link
Member

Yeah definitely, any mention of swift(>=5.7) can be removed.

@Rspoon3
Copy link
Contributor Author

Rspoon3 commented May 10, 2024

@mbrandonw Okay that should be everything now. Let me know if you'd like any other changes.

@mbrandonw
Copy link
Member

Hi @Rspoon3, I think the changes to platforms in the Package.swift is going a little too far. That makes it so that packages that target iOS <16 cannot depend on this package, which means TCA could not even depend on it.

Can you revert that change and bring back all of the availability checks?

@Rspoon3
Copy link
Contributor Author

Rspoon3 commented May 14, 2024

All set.

Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rspoon3!

@mbrandonw mbrandonw merged commit 2c74776 into pointfreeco:main May 14, 2024
2 of 4 checks passed
@Rspoon3 Rspoon3 deleted the shims-removal branch May 15, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants