-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance user magictag #7153
Open
JoryHogeveen
wants to merge
4
commits into
main
Choose a base branch
from
feature/7150-user-magictag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhance user magictag #7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WP_User class implements magic methods which also handles metadata, though it it forced as single values which is incompatible with our intent for pods_v().
JoryHogeveen
added
Type: Bug
Type: Enhancement
Enhancements to features that already exist, but are not major additions
Status: PR > Pending Code Review
PR is pending code review by core developers
Status: PR > QA pending
QA needs to be done
labels
Sep 4, 2023
PR Summary
|
Needs doc update: https://docs.pods.io/displaying-pods/magic-tags/special-magic-tags/#Usage_and_Caveats While not entirely invalid, this bottom part isn't 100% correct in regards to metadata (whether a user pod exists or not) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: PR > Pending Code Review
PR is pending code review by core developers
Status: PR > QA pending
QA needs to be done
Type: Bug
Type: Enhancement
Enhancements to features that already exist, but are not major additions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the {@user.##} magic tag is quite limited to the WP_User object only.
This won't properly support multiple metedata values and also doesn't consider the a possible User Pod.
This PR fixes this by fixing two things:
pods_v()
> Proper order of getting user properties or metadatapods_evaluate_tag()
> If a user Pod exists, it will run the tag through this Pod first.Related GitHub issue(s)
Fixes #7150
Changelog text for these changes
PR checklist