Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run post/page ID through pods_v to trigger filters #7142

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Aug 30, 2023

Description

This PR wraps the return of pods_by_title() through pods_v() to trigger filters and enable translation integrations to convert the ID.

Related GitHub issue(s)

Fixes #7141

Changelog text for these changes

PR checklist

@what-the-diff
Copy link

what-the-diff bot commented Aug 30, 2023

PR Summary

  • Update to 'pods_by_title' Function
    The function 'pods_by_title' in the file 'general.php' has been updated. Instead of providing the '$page' variable straightaway, it now utilizes a function called 'pods_v()'. This update might improve the function's reliability or offer additional functionality.

@JoryHogeveen
Copy link
Member Author

@sc0ttkclark If you are planning on releasing 3.0 instead of a MR feel free to change the milestone!

@sc0ttkclark sc0ttkclark changed the base branch from main to release/3.0 September 4, 2023 04:58
@sc0ttkclark sc0ttkclark merged commit 83869ef into release/3.0 Sep 4, 2023
8 checks passed
@sc0ttkclark sc0ttkclark deleted the feature/7141-translate-auto-templates branch September 4, 2023 04:58
@sc0ttkclark sc0ttkclark modified the milestones: Pods 3.0.1, Pods 3.0 Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto templates are not auto translated anymore
2 participants